Skip to content

Fix GH-16389: Assertion failure in ext/ldap/ldap.c:2718 #16392

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 12, 2024
Merged

Fix GH-16389: Assertion failure in ext/ldap/ldap.c:2718 #16392

merged 1 commit into from
Oct 12, 2024

Conversation

nielsdos
Copy link
Member

@Girgias IIRC the reference support is only in master right, and so this should target master too?

@nielsdos nielsdos linked an issue Oct 12, 2024 that may be closed by this pull request
Assertion failure in ext/ldap/ldap.c:2718 #16389
Closed
Girgias
Girgias approved these changes Oct 12, 2024
View reviewed changes
Copy link
Member

@Girgias Girgias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank for catching this, I did indeed forget to deref this here :|

I do wonder if we shouldn't "merge" the checking and the "actually do stuff" loops together, like it is done in other cases.

But that is a follow-up PR anyway.

@nielsdos
Copy link
Member Author

I do wonder if we shouldn't "merge" the checking and the "actually do stuff" loops together, like it is done in other cases.

Likely, but this isn't too important I feel like and indeed a follow-up anyway

@nielsdos nielsdos merged commit 497dbaa into php:master Oct 12, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Girgias Girgias Girgias approved these changes

Assignees

No one assigned

Labels

Extension: ldap

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Assertion failure in ext/ldap/ldap.c:2718

2 participants

@nielsdos @Girgias